Update publish modal schema #728
Conversation
Signed-off-by: Yash sharma <[email protected]>
|
From today’s call, there was some confusion about whether we should accept this change or not. I think yes, we should, because Uzair's proposal was to migrate these schemas to the schemas repo, which wasn't directly related to fixing the issue. My proposal was to address the issue first. Previously, we had these schemas in the schemas repo, but they were migrated to Sistent. Moving them back to the schemas repo now would require more effort than is currently necessary. For now (right now) I'm focusing on fixing issue not creating extra work which I'm not sure should be a priority, I understand it is nice to have these schemas in schemas repo however I'm not sure if we should put this on priority right now, if we should do then let me know |
|
@MUzairS15 @aabidsofi19 thoughts? |
| }, | ||
| pattern_info: { | ||
| type: 'string', | ||
| title: 'Description', | ||
| description: 'Purpose of the design along with its intended and unintended uses.', | ||
| format: 'textarea', | ||
| 'x-rjsf-grid-area': 12 | ||
| 'x-rjsf-grid-area': 12, | ||
| "x-encode-in-uri": true |
There was a problem hiding this comment.
@Yashsharma1911 these are native to rjsf right ? . if not where are we documenting these . we should be using a uiSchema and not putting the presentation specific properties in the data structure schema
There was a problem hiding this comment.
I agree @aabidsofi19 we can move it to uiSchema, we are tracking them here - https://github.com/layer5io/sistent/blob/master/src/schemas/readme.md#custom-properties
There was a problem hiding this comment.
Also in RJSF section in Meshmap developer guide
There was a problem hiding this comment.
Ops sorry, I mean "Kanvas"
|
i think the publish schema should be derived from the schema for input of the publish endpoint . to remove the redundancy of redefining the same properties . for the presentation we should use a separate uiSchema ( that defines ui like the widget to use, grid size etc not the data structure ) |
|
A relevant discussion - meshery/meshkit#584 (comment) |
This makes much more sense, we can update the capability of uiSchema to support this, and one part is to move them in single place, it does make sense for me if these schemas get bundled in schema repo npm package. |
Notes for Reviewers
This PR fixes #
This PR adds missing parameter in publish modal RJSF schema which tell RJSF to decode input data in URI encoded format and show data in input field in decoded format
Signed commits